Document workers I/O errors with examples #16965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
requested review from
a team,
irvinebroque,
mikenomitch and
rohinlohe
as code owners
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
irvinebroque
approved these changes
Sep 24, 2024
Contributor
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
✅ so that we can ship, can always revisit and improve
| export default { | ||
| async fetch(request, env, ctx) { | ||
| if (this.resp === undefined) { | ||
| globalThis.resp = await fetch('https://example.com'); |
Contributor
There was a problem hiding this comment.
easier to understand by setting a global variable outside of the fetch handler? Since that is from what I've seen also the more common footgun, and illustrates the point of — don't do things in global scope outside of the handler!
Contributor
|
Confirmed with @jasnell over chat to switch this to draft for now |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist